statusbar: Deprecate style properties

We were not really using the shadow-type style property anyway,
so lets just deprecate it. Themes can directly theme the frame.

diff --git a/gtk/gtkstatusbar.c b/gtk/gtkstatusbar.c
index b5ee3244f43995bc2d8aef4b36a242cc046caab6..258e27dea13d545203785032b2cbd27d680bf18f 100644 (file)
--- a/gtk/gtkstatusbar.c
+++ b/gtk/gtkstatusbar.c
@@ -165,13 +165,21 @@ gtk_statusbar_class_init (GtkStatusbarClass *class)
                  G_TYPE_UINT,
                  G_TYPE_STRING);
 
+  /**
+   * GtkStatusbar:shadow-type:
+   *
+   * The style of the bevel around the statusbar text.
+   *
+   * Deprecated: 3.20: Use CSS properties to determine the appearance,
+   *    the value of this style property is ignored.
+   */
   gtk_widget_class_install_style_property (widget_class,
                                            g_param_spec_enum ("shadow-type",
                                                               P_("Shadow type"),
                                                               P_("Style of bevel around the statusbar text"),
                                                               GTK_TYPE_SHADOW_TYPE,
                                                               GTK_SHADOW_IN,
-                                                              GTK_PARAM_READABLE));
+                                                              GTK_PARAM_READABLE|G_PARAM_DEPRECATED));
 
   /* Bind class to template
    */
@@ -188,7 +196,6 @@ static void
 gtk_statusbar_init (GtkStatusbar *statusbar)
 {
   GtkStatusbarPrivate *priv;
-  GtkShadowType shadow_type;
 
   statusbar->priv = gtk_statusbar_get_instance_private (statusbar);
   priv = statusbar->priv;
@@ -199,10 +206,7 @@ gtk_statusbar_init (GtkStatusbar *statusbar)
   priv->keys = NULL;
 
   gtk_widget_init_template (GTK_WIDGET (statusbar));
-
   gtk_widget_set_redraw_on_allocate (GTK_WIDGET (statusbar), TRUE);
-  gtk_widget_style_get (GTK_WIDGET (statusbar), "shadow-type", &shadow_type, NULL);
-  gtk_frame_set_shadow_type (GTK_FRAME (priv->frame), shadow_type);
 }
 
 /**

diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 8dbd62d6da669a80c6efcf54277d60507ad32c38..5e8c791e0bdd40cbc64c0e3bc978579d2ccee3d7 100644 (file)
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -31,8 +31,6 @@ $asset_suffix: if($variant=='dark', '-dark', '');
   -GtkDialog-button-spacing: 4;
   -GtkDialog-action-area-border: 0;
 
-  -GtkStatusbar-shadow-type: none;
-
   // We use the outline properties to signal the focus properties
   // to the adwaita engine: using real CSS properties is faster,
   // and we don't use any outlines for now.

diff --git a/gtk/theme/Adwaita/gtk-contained-dark.css b/gtk/theme/Adwaita/gtk-contained-dark.css
index 445f66184a7565f0ee048ff1d929baa748d7ad30..06d2cd13c7477ff23320efb77b4e08202a62f5a3 100644 (file)
--- a/gtk/theme/Adwaita/gtk-contained-dark.css
+++ b/gtk/theme/Adwaita/gtk-contained-dark.css
@@ -12,7 +12,6 @@
   -GtkWidget-text-handle-height: 24;
   -GtkDialog-button-spacing: 4;
   -GtkDialog-action-area-border: 0;
-  -GtkStatusbar-shadow-type: none;
   outline-color: rgba(238, 238, 236, 0.3);
   outline-style: dashed;
   outline-offset: -3px;

diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css
index 434b44948f1e0d8a4b510d75b1be9aa64b6f49ad..d72301ee9e782c25dc82f9e3a01c702ca5a5e19c 100644 (file)
--- a/gtk/theme/Adwaita/gtk-contained.css
+++ b/gtk/theme/Adwaita/gtk-contained.css
@@ -12,7 +12,6 @@
   -GtkWidget-text-handle-height: 24;
   -GtkDialog-button-spacing: 4;
   -GtkDialog-action-area-border: 0;
-  -GtkStatusbar-shadow-type: none;
   outline-color: rgba(46, 52, 54, 0.3);
   outline-style: dashed;
   outline-offset: -3px;